[UR] Make command-buffer creation descriptor mandatory #17058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
Feb 19, 2025
Bensuo
approved these changes
Feb 19, 2025
As discussed in oneapi-src/unified-runtime#2670 (comment) the `pCommandBufferDesc` parameter to `urCommandBufferCreateExp` is optional. However, the UR spec doesn't state what the configuration of the created command-buffer is when this isn't passed, and being optional is also inconsistent with the description parameters to urSamplerCreate & urMemImageCreate which are not optional. This PR updates the descriptor parameter to command-buffer creation to be mandatory to address these concerns. Closes oneapi-src/unified-runtime#2673
EwanC
force-pushed
the
command-buf_descriptor
branch
from
70d2694 to
0173bf6
Compare
|
@intel/llvm-gatekeepers This is ready to merge thanks |
sommerlukas
pushed a commit
that referenced
this pull request
May 15, 2025
Closes issue #18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored. Also fixes up an artifact in the UR command-buffer spec where it says that descriptors to the command-buffer creation API can be optional, when after #17058 they are mandatory.
github-actions bot
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
May 16, 2025
Closes issue intel/llvm#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored. Also fixes up an artifact in the UR command-buffer spec where it says that descriptors to the command-buffer creation API can be optional, when after intel/llvm#17058 they are mandatory.
kbenzie
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
May 19, 2025
Closes issue intel/llvm#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored. Also fixes up an artifact in the UR command-buffer spec where it says that descriptors to the command-buffer creation API can be optional, when after intel/llvm#17058 they are mandatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in oneapi-src/unified-runtime#2670 (comment) the
pCommandBufferDescparameter tourCommandBufferCreateExpis optional. However, the UR spec doesn't state what the configuration of the created command-buffer is when this isn't passed, and being optional is also inconsistent with the description parameters to urSamplerCreate & urMemImageCreate which are not optional. This PR updates the descriptor parameter to command-buffer creation to be mandatory to address these concerns.Closes oneapi-src/unified-runtime#2673
Note: This UR patch was previously approved and ready-to-merge in oneapi-src/unified-runtime#2676 prior to the repo move